Remove SourceLink package reference #6430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Interestingly, this has |
peppy
approved these changes
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've been seeing some hot reload failures of the form:
error ENC0003: Updating 'attribute' requires restarting the applicationThis is caused by SourceLink, which wants to write the git hash to the
AssemblyInfoobj file.Trail starts here: dotnet/sourcelink#1144
SourceLink is included starting with the .NET 8 SDK, and I've tested that SourceLink is still working -
dotnet packand check the.nuspecin the contained package:sh $ cat ppy.osu.Framework.nuspec | grep rep <repository type="git" url="https://github.com/ppy/osu-framework" commit="270b29d58b736deca2b6d76fe9907b2554d5979f" />